search

UKGovLD / registry-core

Linked data registry - core application and example UI
https://github.com/UKGovLD/registry-core/wiki
Apache License 2.0
23 stars 9 forks source link

Registry enhancements (FSA) #127

Closed simonoakesepimorphics closed 3 years ago

simonoakesepimorphics commented 4 years ago

Add language sorting function for UI templates. Add CSV value language sorting.

simonoakesepimorphics commented 4 years ago

Code looks great but the sort order looks to be by lexical form of the language code. Specifically for the FSA use case this will put cy before en which feels backwards. While I guess this doesn't really matter in the CSV it would be more convenient to have the majority language first even there and for the order to be consistent with UI. For the UI is there not already a notion of a preferred/default language from a prior round of changes?

There's currently no preferred language concept, however there is one in the multilingual UI feature.

der commented 4 years ago

There's currently no preferred language concept, however there is one in the multilingual UI feature.

So does it make sense to use that preferred language if set and otherwise sort so en comes first?