search

UKGovLD / registry-core

Linked data registry - core application and example UI
https://github.com/UKGovLD/registry-core/wiki
Apache License 2.0
23 stars 9 forks source link

Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 #195

Closed dependabot[bot] closed 8 months ago

dependabot[bot] commented 11 months ago

Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/UKGovLD/registry-core/network/alerts).
tendrie commented 8 months ago

Hello, @der we have a security issue concerning apache derby (as in trivy.txt) This pull request will solve the problem. Could you please check it for us? We will perform tests on our part.

Best

der commented 8 months ago

Hi @tendrie. Looks fine to me, I've merged but there's also some lower severity shiro updates to merge as well. Let me know who your tests look and whether we need to crank a new release.

tendrie commented 8 months ago

Hi @der ,

We have performed some tests from the latest commit. It seems that derby 10.17 is not compatible with the 10.14. The former userstore is not recognize by the latest one, and there are errors on missing dependencies. My point is that in the short time, 10.14.2 => 10.14.3 will solve temporarily the security issue, but the medium-term objective will be to perform the upgrade to 10.17.

image

image

der commented 8 months ago

Hi @tendrie ,

Many thanks for testing.

Yes, I can see that Derby 10.17 requires java 21 or better. That really should have been a major version increment! So that would require a rather larger job to qualify registry-core for java 21 and even so I'm aware that some users are on earlier java platforms. Might require splitting into multiple artefacts for different java versions, which is far beyond what we do right now.

I can't see a 10.14.3.x in either the Derby releases page or Maven central.

Dave /cc @simonoakesepimorphics