search

UKGovernmentBEIS / inspect_ai

Inspect: A framework for large language model evaluations
https://UKGovernmentBEIS.github.io/inspect_ai/
MIT License
385 stars 41 forks source link

Required Docker Version #69

Closed kaifronsdal closed 23 hours ago

kaifronsdal commented 3 days ago

In the latest version of inspect, docker has a minimum requirement of 24.0.7 and docker compose has a minimum requirement of 2.22.0. However, it seems as though this requirement is solely for the docker compose pull '--policy' option. However, this is only ever used if not building/using something local.

if (
    service.get("build", None) is None
    and service.get("x-local", None) is None
):

Would it be possible to either override this check, or only check this requirement if using pull is necessary. I am sadly stuck with docker 24.0.6 and do not have permissions to upgrade. I'm happy to make a pull request if needed.

jjallaire commented 1 day ago

Do you know what version of Docker Compose is included in 24.0.6?

I think what we'd probably do here is ratchet the default versions requirements back and then run another Docker Compose version check right before we pull.

kaifronsdal commented 1 day ago

I'm stuck with Docker Compose version 2.21.0

aisi-inspect commented 1 day ago

Okay thanks, I'll bump it down to that then re-check if we are going to pull.

jjallaire commented 23 hours ago

That change has been made here: https://github.com/UKGovernmentBEIS/inspect_ai/commit/9cdf8e748d0357bb2b356116c0785d919047bbce