search

UKHO / admiralty-design-system

MIT License
4 stars 0 forks source link

[BUG] Header items with No Sub Items should be links #158

Closed LukeTaylor34 closed 1 week ago

LukeTaylor34 commented 7 months ago

Description Using a button instead of link to navigates users voids the inbuilt functionality that 'a' tags have. Such as telling assistive tech user the href to inform them of the destination, assistive tech tools provide a list of links, headings and landmarks that user can use to short cuts to navigate too.

Expected behaviour The 'button' element should be used for any interaction that performs an action on the current page. The 'a' element should be used for any interaction that navigates to another view.

Screenshots image

KatiePUX commented 3 months ago

Tickets 114, 157, 178, 149 linked - let team Kai know when you are working on these so they can make adjustments when required