search

UKHO / admiralty-design-system

MIT License
4 stars 0 forks source link

[BUG] When entry is valid, the admiralty input spacing gets smaller #173

Closed KatiePUX closed 1 month ago

KatiePUX commented 6 months ago

Describe the bug If you put a valid entry into the input field the admiralty input invalid spacing gets smaller. This is causing the page to bounce as the user completes a form.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'UKHO data upload' > 'Send a new survey'
  2. Click 'Name of survey' input field, enter 'K'
  3. See error

Expected behavior Spacing to not change and to be consistent with all input fields in the design system

Screenshots If applicable, add screenshots to help explain your problem.

  1. image

  2. image

ecstaticrainbow commented 5 months ago

Spoke to Katie and Luke, to resolve this issue we will remove the reserved space for the input error, this should bring everything closer together and also should fix the bouncing around issue. We are happy with the fact the page will stretch vertically when an error does exist but that is how GDS do it and other design systems. It is also worth checking that the CSS rules are setup correctly for the input error so that it doesn't drag the input around when it shows and doesnt show