search

UKHO / admiralty-design-system

MIT License
5 stars 0 forks source link

[BUG] ARC Tool issue - aria-hidden used on focusable. #215

Closed Satyam15302 closed 2 weeks ago

Satyam15302 commented 3 months ago

Describe the Bug

An aria-hidden="true" attribute is used on a focusable <input> element. This makes the input inaccessible to assistive technologies and disrupts keyboard navigation, violating WCAG 2.2 Success Criterion 2.1.1 (Keyboard).

To Reproduce

Steps to reproduce the behavior:

  1. Open the "Selecting ENCs" page from FSS.
  2. Locate the "Click to choose a file" upload button.
  3. Use a web accessibility testing tool like ARC Toolkit.
  4. Observe the error indicating the aria-hidden attribute is incorrectly applied to the focusable file input element.

Expected Behavior

Focusable elements like inputs should not have aria-hidden="true", as it hides them from assistive technologies. Instead, ensure the element is both focusable and visible to all users.

Screenshots

aria-hidden used on focusable

Additional Context

This issue affects the file upload control used for adding ENC lists. The file input field is hidden with aria-hidden="true", but it remains focusable, leading to confusion and accessibility barriers. Removing the aria-hidden attribute or adjusting its usage ensures that the element is both visible and operable by all users, including those using assistive technologies.

KatiePUX commented 2 weeks ago

review - potentially fixed

buzzub commented 2 weeks ago

Resolved by #116