search

UKHO / docs

Documentation around digital development project, teams, behaviors and processes at the UKHO
MIT License
20 stars 11 forks source link

CI needs to point back to master branch #113

Closed benbhall closed 4 years ago

benbhall commented 4 years ago

Went to test this and remembered we are still on master, whereas I wrote the CI yml on my repo with a default of main.

Changing it to master for the time being.

Also adding missing package.json. The perils of lift and shift from testing it elsewhere! :)

benbhall commented 4 years ago

Here you go @nevillejrbrown if you want to see the results against ukho/docs.

elduddz commented 4 years ago

How about adding main and master to the trigger?

elduddz commented 4 years ago

Or... Get on main now.

nevillejrbrown commented 4 years ago

I think it might be over-sensitive here: "Be careful with UK, it’s profane in some cases".

Lots of other false positives too. But it did spot a 'whitelist'!

benbhall commented 4 years ago

I think it might be over-sensitive here: "Be careful with UK, it’s profane in some cases".

Lots of other false positives too. But it did spot a 'whitelist'!

Like introducing nullable reference types in C# to a large existing solution and 200 warnings pop up :) Always tricky introducing any such checks to existing sources. I'm sure if it was plugged in from the start on a piece, with the equivalent extension in the editor (available for most IDEs), then we'd stay on top of tweaking rules.

I'll have a bash at dialling it back a bit in some config today on this branch. This repo is a good testing ground.

benbhall commented 4 years ago

How about adding main and master to the trigger?

🤦‍♂️ ofc hehe

benbhall commented 4 years ago

How about adding main and master to the trigger?

🤦‍♂️ ofc hehe

Okay I've set workflow to trigger for master or main for now if I could get an approve please and will open up another branch to refine Alex.js.