UKHomeOffice-attic / hof

Home Office Forms
GNU General Public License v2.0
14 stars 6 forks source link

Should we use hmpo-model as the session model? #95

Open daniel-ac-martin opened 8 years ago

daniel-ac-martin commented 8 years ago

In the recent spirit of questioning HOF's entire architecture, is it worth thinking about whether we should be using hmpo-model for sessions? Isn't there a whole load of stuff in there for talking to RESTful APIs? Couldn't we have something simpler?

JoeChapman commented 8 years ago

There are occasions when we need to talk to RESTful API's.

easternbloc commented 8 years ago

There are occasions when we need to talk to RESTful API's.

This is true although a more basic model might be valid for the hof core.

daniel-ac-martin commented 8 years ago

@JoeChapman: But do those occasions occur when using the session model?

JoeChapman commented 8 years ago

It might be, but is it a priority?

easternbloc commented 8 years ago

It might be, but is it a priority?

No, but I think while we're questioning all the things it warrants a question. We need to have a list of all the stuff we think needs addressing and then we can just label them on a roadmap.

Sound good?

JoeChapman commented 8 years ago

That sounds fine. However, I actually think it's useful to have the RESTful API code. But maybe split them? I do however, think that because of the fresh look we are taking at HOF, that it might be in our interest to stop using other components in the HOF ecosystem, i.e. HMPO-wizard/HMPO-controller. Not least because they don't have the same obligation to ask for our feedback when making code changes to HMPO code that we do to HMPO code

easternbloc commented 8 years ago

But maybe split them?

Yus! With regards to the other comments I think they're perfectly valid options and should be raised as further issues. We don't have to do everything that's raised as an issue but it's good to capture our thoughts and discuss them openly here.

JoeChapman commented 8 years ago

Didn't mean to sound argumentative. I should put smiley faces next to all my comments. Just so you know I love you @daniel-ac-martin :)

easternbloc commented 8 years ago

@JoeChapman