search

UKHomeOffice / design-system

Home Office Design System
https://design.homeoffice.gov.uk
76 stars 22 forks source link

Fix: Failing Build on scan-app Action #586

Closed jremes-ho closed 3 months ago

jremes-ho commented 3 months ago

Good afternoon.

"Scan service for vulnerabilities" workflow was failing because owasp/zap2docker Docker image does not exist any longer, it has been deprecated and replaced with owasp/zaproxy image with following error:

Error response from daemon: pull access denied for owasp/zap2docker, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

I have upgraded two actions in this workflow:

This should fix the failing scan.

Thank you.

daniel-ac-martin commented 3 months ago

Thanks again @jremes-ho.

I should have noticed and pulled in the update from upstream: https://github.com/daniel-ac-martin/NotGovUK/blob/master/.github/actions/scan-app/action.yml