search

UKHomeOffice / engineering-guidance-and-standards

Engineering Guidance and Standards for the Home Office
https://engineering.homeoffice.gov.uk
MIT License
14 stars 2 forks source link

npm: bump @x-govuk/govuk-eleventy-plugin from 5.0.6 to 5.0.7 #356

Closed dependabot[bot] closed 6 months ago

dependabot[bot] commented 6 months ago

Bumps @x-govuk/govuk-eleventy-plugin from 5.0.6 to 5.0.7.

Release notes

Sourced from @​x-govuk/govuk-eleventy-plugin's releases.

v5.0.7

  • Add href to current item in navigation fbeebd0
  • Remove Node 16 from test workflow matrix 605e332
  • Complete test coverage for markdown-it 260c08a
  • Complete test coverage for utility functions 7a198a8
  • Complete test coverage for date filter e759887
  • Use node test runner 8acc948
  • Update dependencies 96c6582

https://github.com/x-govuk/govuk-eleventy-plugin/compare/v5.0.6...v5.0.7

Commits
  • cfb443d 5.0.7
  • fbeebd0 Add href to current item in navigation
  • 605e332 Remove Node 16 from test workflow matrix
  • 260c08a Complete test coverage for markdown-it
  • 7a198a8 Complete test coverage for utility functions
  • e759887 Complete test coverage for date filter
  • 8acc948 Use node test runner
  • 96c6582 Update dependencies
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
robertdeniszczyc2 commented 6 months ago

This is flagged as a minor patch update but I feel it's a bit more than a minor looking at the release notes. The plugin has changed the test runner from ava to the new node test runner. The new test runner is now Stable, but in this change it's now using experimental coverage feature.

Recommend properly testing this before progressing.

More info about node test runner: https://nodejs.org/docs/latest-v20.x/api/test.html

dependabot[bot] commented 6 months ago

Superseded by #358.

jeff-horton-ho-sas commented 6 months ago

This is flagged as a minor patch update but I feel it's a bit more than a minor looking at the release notes. The plugin has changed the test runner from ava to the new node test runner. The new test runner is now Stable, but in this change it's now using experimental coverage feature.

Recommend properly testing this before progressing.

More info about node test runner: https://nodejs.org/docs/latest-v20.x/api/test.html

We're not using that test runner (EG&S only uses Cypress for testing), so that only affects their internal testing.

In any case - v6 has now been released which is a major update and had breaking changes, see https://github.com/UKHomeOffice/engineering-guidance-and-standards/pull/360