UKHomeOffice / engineering-guidance-and-standards

Engineering Guidance and Standards for the Home Office
https://engineering.homeoffice.gov.uk
MIT License
14 stars 2 forks source link

Use UK formatted date for postDate filter #390

Closed jeff-horton-ho-sas closed 3 months ago

jeff-horton-ho-sas commented 4 months ago

Code change

I can confirm:

Accessibility considerations

LiamMacP commented 3 months ago

I've decided to specify an explicit date format as that expresses the intent more clearly than changing the locale in the Dockerfile.

Is there any side effect from doing both? No issues with this immediate change, but the lower level change should propagate more cleanly. Even at the expense of slight unclarity.

jeff-horton-ho-sas commented 3 months ago

I've decided to specify an explicit date format as that expresses the intent more clearly than changing the locale in the Dockerfile.

Is there any side effect from doing both? No issues with this immediate change, but the lower level change should propagate more cleanly. Even at the expense of slight unclarity.

Good point. I've added localisation to build image.