UKHomeOffice / engineering-guidance-and-standards

Engineering Guidance and Standards for the Home Office
https://engineering.homeoffice.gov.uk
MIT License
14 stars 2 forks source link

WIP: Documenting an API standard #403

Open aaronrussellHO opened 2 months ago

aaronrussellHO commented 2 months ago

Code change

I can confirm:

Accessibility considerations

I can confirm:

daniel-ac-martin commented 2 months ago

I think there are some things missing here that we might want to think about:

We don't need to have answers to all of those right now, but I think we should bear them in mind.

daniel-ac-martin commented 2 months ago

We might also want to think about GraphQL.

daniel-ac-martin commented 2 months ago

Related:

aaronrussellHO commented 2 months ago

I think there are some things missing here that we might want to think about:

  • What format should be used to document APIs? (e.g. OpenAPI)
  • Is a specification enough? (I think it needs to be supplemented with more traditional documentation.)
  • Where should the docs live?
  • Is it acceptable to generate specifications from implementation code? (I generally prefer a specification-first approach.)
  • How should docs be made available? - As a website, or is a raw spec enough? (Maybe this is covered as a part of the catalogues?)

We don't need to have answers to all of those right now, but I think we should bear them in mind.

We spoke about this in the guild meeting, and some of this we think may be better as a pattern to show how you might want to document something, without been an explicit must.

aaronrussellHO commented 3 weeks ago

To be included: