search

UKHomeOffice / eslint-config-homeoffice

MIT License
0 stars 2 forks source link

Update eslint and dependencies #13

Closed joefitter closed 8 years ago

joefitter commented 8 years ago
joefitter commented 8 years ago

@JoeChapman @easternbloc @merlinc @noels mind having a 👀 over this?

joefitter commented 8 years ago

@JoeChapman @easternbloc @merlinc @noels bump!

merlinc commented 8 years ago

@joefitter Oops, this got lost in the ether. Looking now :)

merlinc commented 8 years ago

So this upgrades eslint to v2, which is great and long overdue!

Are there many new rules - this is just looking like syntactic renames - I'd expected a few new rules to need to be defined.

joefitter commented 8 years ago

It looks as though more has been removed/renamed than actually added. There is some handy es6 stuff though like prefer const over let etc - we should use these but out of scope of this PR I guess

joefitter commented 8 years ago

I still stand by binning this in favour of https://github.com/feross/standard

joefitter commented 8 years ago

although @easternbloc may still need a lot of convincing. The fact that this repo even exists justifies binning it for a sensible set of defaults that never have to be maintained IMHO. Ima keep plugging it until somebody listens ;)

merlinc commented 8 years ago

@joefitter Yeah - @chrisns convinced me that each project should choose existing standards that match the style of thing it's doing. Angular projects should follow their own eco-system standards and not be forced to comply to expressjs standards (for example).

At best I think this project could be a eslint-config-HOF, but even then I'm still dubious about it.

Standard is better than nothing, but IMHO eslint does proper checking for language syntax bugs, together with understanding that test and source directories have different requirements for testing.

joefitter commented 8 years ago

Standard is built on top of eslint and uses sensible defaults, including test I believe. The main point being the end developer doesn't have to worry about configuring and maintaining, updating etc, a .eslintrc file and just concentrates on developing the app

daniel-ac-martin commented 8 years ago

This LGTM but I'm not an expert on eslint. Would be nice to get this upgraded. @easternbloc, @JoeChapman: Any thoughts?

easternbloc commented 8 years ago

LGTM