Open merlinc opened 8 years ago
As the version of eslint only affects the code it it is linting, I vote for using the latest version and most up-to-date config names. When adding this module to most projects there would be breaking style changes anyway, as most projects aren't on the same rules.
When adding this module to most projects there would be breaking style changes anyway, as most projects aren't on the same rules.
A LOT of projects using hof are using that version of eslint so I think we need to be careful here. Perhaps we can release versioned configs to ease migration?
@easternbloc @HughePaul Given the tweaks in rules, we will definitely need to update various bits of our project code to meet the new 1.0 and 2.0 standards. Versioned configs is definitely a must, probably with our migration guide explaining what rules we know have changed. These could be siblings to the existing eslint migration guides:
Also, other teams have already started migrating so we should probably take some notes from them too
https://github.com/UKTradeInvestment/contact-ukti/blob/master/package.json#L79
I like that idea @merlinc
We need to be mindful that there are a number of forms in SO that will be using the old config.
Another reason to upgrade: I tried to override no-underscore-dangle
on a case by case basis, but this feature isn't available until v1.7.0 - so I now have to have a blanket override while we decide what to do with our variable names.
The SO forms are being redeveloped and as such will - are, in some cases - use(ing) eslint@v2.9.0
, which has introduced a number of new rule names and deprecated a number of other rules.
@JoeChapman Did you start from the same basic config with eslint 0.23
? If so, do you have any examples to share of updated configuration working with eslint 2.x
? We could pull them into this eslint module and use it to provide an upgrade path.
@merlinc we did start from the same basic config but have not yet updated our config. (only updated eslint version very recently) We'll share as it becomes available though.
I did this a while back - will try and dig it out
Eslint is currently released at version 2.x, but we are using eslint 0.23.0. This obviously makes it difficult to keep up to date with bug fixes and features.0
There are a number of breaking changes that we will need to account for, and a few new rules to decide on.