UKHomeOffice / snowtify

A utility to connect a CD pipeline to the ServiceNow API.
GNU General Public License v3.0
2 stars 4 forks source link

Run end-to-end tests in CI? #52

Open daniel-ac-martin opened 4 years ago

daniel-ac-martin commented 4 years ago

The end-to-end tests are currently only run after a push to master and only after the docker image has already been pushed.

Instead it would be better to run those end-to-end tests earlier. That way we can avoid pushing a broken image and potentially breaking people's CD pipelines.

I'm not sure if this should be done earlier in the push to master pipeline or whether we should do it on pull requests as well. (It might be a security risk. - Although it shouldn't really...)