search

UKHomeOfficeForms / hof-form-wizard

MIT License
0 stars 2 forks source link

Fix - Add 'trim', 'singlespaces', 'hyphens' to default formatters #23

Closed sulthan-ahmed closed 6 years ago

sulthan-ahmed commented 6 years ago

Add a test for this too

lennym commented 6 years ago

Looks legit. I'm not a fan of the inconsistent npm script naming (either prefix with test: or don't, but do the same everywhere) but that's not in scope here.

(although I would merge the hell out of a PR that made it consistent while you have the code open)

sulthan-ahmed commented 6 years ago

so you would have done "unit": "_mocha" instead?

lennym commented 6 years ago

Or made the other test scripts be test:thing. Either is fine, but they should be consistent.

(I have a mild preference towards test:*)