Devtask - ES6ify

[joefitter]

• updated to use es6 code
• installed eslint-config-homeoffice
• fixed code in line with linter
• use hof-model

[joefitter]

@JoeChapman @easternbloc @danielepolencic - mind having a look when you get a sec please?

[JoeChapman]

@joefitter @lennym is this still relevant considering our conversation this afternoon about restructuring the controllers?

[joefitter]

why wouldn't it be? all this is doing is refactoring to es6, which we would need to do if we moved the controller to hof-controllers anyway

[lennym]

Is this PR good to merge? If it is then it would be good to merge before the restructure so the work's not lost.

I'm assuming that's what @joefitter was getting at.

[lennym]

Tests are failing for me locally. Not sure why this hasn't been travis-ed.

[joefitter]

@lennym looking now, its pretty old so not surprised its failing

[lennym]

It's failing outside the controllers, so I'll copy the ES6 controller code into hof-form-controllers (because eslint in that project freaks out if I copy the master code).

[joefitter]

sounds good, I'll fix this branch and then PR the removal of the controllers

[joefitter]

@lennym looks like travis was turned off for a few repos, including hof-form-controller. I have enabled it now

[joefitter]

@JoeChapman @easternbloc @lennym passing now, mind giving this a 👍