search

UKHomeOfficeForms / hof-form-wizard

MIT License
0 stars 2 forks source link

Feature - use behaviours #9

Closed joefitter closed 7 years ago

joefitter commented 7 years ago

This PR removes the dependency on hof-controllers and instead installs hof-form-controller ^3.0.1 which already has hooks and session IO mixed in. Also installed mixwith.js so steps can now provide one or more custom "behaviours" in place of a singular custom controller. Custom controllers are still supported but a deprication warning is now shown if a custom controller is used.

joefitter commented 7 years ago

@lennym would like your input if you get time, tomorrow is fine though

lennym commented 7 years ago

Looks pretty good overall. I just have a few minor points and clarifications. The biggest thing for me is being clear on what order behaviours get mounted in.

joefitter commented 7 years ago

@lennym howzat?

joefitter commented 7 years ago

@lennym @JoeChapman @easternbloc updated - I removed the test as its just for a deprecation warning - stubbing the console was trivial, but stubbing deprecate would require re-installing proxyquire, which seems like overkill for a warning

lennym commented 7 years ago

That is 100% fine by me.

joefitter commented 7 years ago

lennym commented 7 years ago

easternbloc commented 7 years ago

@joefitter i love that guy he's the happiest little birthday person on the planet

joefitter commented 7 years ago

It is literally my favourite gif ever