UKHomeOfficeForms / hof-template-partials

DEPRECATED, this is built into hof v19 (ノ◕ヮ◕)ノ*:・゚✧
0 stars 3 forks source link

Unescape page titles #23

Closed lennym closed 7 years ago

lennym commented 7 years ago

Where a page title already contains templated content - e.g. inserting user input from previous steps - then the values are already escaped, and so should not be escaped again, as this results in raw html entities being output to the page - e.g. ' instead of a single-quote/apostrophe.

Remove the escaping here since the title is rendered from a templated value, which is already therefore escaped.

Before:

screen shot 2017-05-12 at 12 06 59

After:

screen shot 2017-05-12 at 12 04 32

A slightly better "after" without the XSS check:

screen shot 2017-05-12 at 12 13 27