SD-95 - Address package vulnerabilities

agraham19 commented 3 years ago

This pull request updates mocha to fix vulnerabilities. The previous version was very old, so it necessitated other changes.

update mocha version
update istanbul to nyc
update sinon
update sinon-chai
replace supertest-as-promised with latest supertest (this now supports promises)
remove sinomocha as it breaks under latest mocha
amend tests to run under new mocha version
use standard naming pattern for test files
split index.spec.js (bootstrap.spec.js and server.spec.js) into two smaller files

AlexFranklinHODDaT commented 3 years ago

Can we add test/.DS_STORE to gitignore?

agraham19 commented 3 years ago

Can we add test/.DS_STORE to gitignore?

I have been advised previously not do this as it should be in our global ignore.

UKHomeOfficeForms / hof