UKHomeOfficeForms / hof

Bootstrap a HOF project
MIT License
15 stars 17 forks source link

HOFF-369-pdf-converter #409

Open RobertMcCann opened 11 months ago

RobertMcCann commented 11 months ago

Relates: ASCS-286 && HOFF-369

What Change references of Request to Axios in html-pdf-converter

Why Services such as ASC use the extended html-pdf-converter which was using Request references such as response.body which should be response.data

Notes:

line 208: parseError(statusCode, data) { return Object.assign({ status: statusCode }, data); }

This is because Axios now handles the bad errors after failing to resolve a promise. The team agreed it would be best to handle the errors using a hof error class so that in future when replacing Axios there wouldn't be as much technical debt, however this issue has now been decoupled from this ticket and can be found here: HOFF-519

Testing TBC