issues
search
UKHomeOfficeForms
/
hof
Bootstrap a HOF project
MIT License
15
stars
17
forks
source link
HOFF-648: Fixed typo causing spacing issues found when updating nrm to latest hof version
#455
Closed
Rhodine-orleans-lindsay
closed
5 months ago
Rhodine-orleans-lindsay
commented
5 months ago
What?
Fixed typo causing spacing issues between label hit and error message on select fields found when updating nrm to latest hof version as part of
HOFF-648
Why?
Hint and error message were incorrectly in select label tag causing spacing issues -
https://design-system.service.gov.uk/components/select/
How?
Moved hint and error message out of select label tag in frontend/template-mixins/partials/forms/select.html
Testing?
Tested on other services
Screenshots (optional)
Govuk Design system example:
Current design with typo in service:
Fix tested in service:
Anything Else? (optional)
Check list
[x] I have reviewed my own pull request for linting issues (e.g. adding new lines)
[x] I have written tests (if relevant) - not applicable
[x] I have created a JIRA number for my branch
[x] I have created a JIRA number for my commit
[x] I have followed the chris beams method for my commit
https://cbea.ms/git-commit/
here is an
example commit
[x] Ensure drone builds are green especially tests
[x] I will squash the commits before merging
What?
Why?
How?
Testing?
Screenshots (optional)
Govuk Design system example:
Current design with typo in service:
Fix tested in service:
Anything Else? (optional)
Check list