UKPLab / framenet-tools

Annotate text with FrameNet frames and arguments.
Apache License 2.0
10 stars 2 forks source link

Updated tqdm code and renamed a variable #22

Closed girishponkiya closed 4 years ago

girishponkiya commented 4 years ago
  1. Updated tqdm code to prevent it from writing a new line for each iteration. Now, it updates the progress for a loop in the same line.
  2. Renamed a variable (from dir to _dir) to avoid possible conflict as dir is an inbuilt keyword.
codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0a77e2e). Click here to learn what that means. The diff coverage is 79.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   78.91%           
=========================================
  Files             ?       30           
  Lines             ?     2419           
  Branches          ?        0           
=========================================
  Hits              ?     1909           
  Misses            ?      510           
  Partials          ?        0           
Impacted Files Coverage Δ
framenet_tools/main.py 71.83% <0.00%> (ø)
...menet_tools/frame_identification/frameidnetwork.py 88.51% <82.35%> (ø)
...ramenet_tools/span_identification/spanidnetwork.py 96.63% <84.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a77e2e...8012e53. Read the comment docs.

jcklie commented 4 years ago

Thank you!