UKPLab / framenet-tools

Annotate text with FrameNet frames and arguments.
Apache License 2.0
10 stars 2 forks source link

Simple bug in download option in framenet_tools/main.py #28

Closed djinn-anthrope closed 4 years ago

djinn-anthrope commented 4 years ago

Describe the bug On using framenet_tools download with a path specific option, throws an error about argparser options

To Reproduce Steps to reproduce the behavior:

  1. framenet_tools download --path path/to/tools

If possible, attach a minimal file that triggers the error. https://github.com/inception-project/framenet-tools/blob/5c284c5f1c228b9f61a4198f342e0b9eb07b29ca/framenet_tools/main.py#L106

Expected behavior Tools downloaded

Error message

Traceback (most recent call last):
  File "/home/user/framenet_tools", line 33, in <module>
    sys.exit(load_entry_point('framenet-tools', 'console_scripts', 'framenet_tools')())
  File "/home/user/framenet-tools/framenet_tools/main.py", line 187, in main
    eval_args(parser)
  File "/home/user/framenet-tools/framenet_tools/main.py", line 106, in eval_args
    check_files(os.path.join(os.getcwd(), parsed.download))
AttributeError: 'Namespace' object has no attribute 'download'

Please complete the following information:

Additional context Simple namespace change needed. Sorry for the bother!