search

UKPLab / framenet-tools

Annotate text with FrameNet frames and arguments.
Apache License 2.0
10 stars 2 forks source link

Change in argument parser call #29

Closed djinn-anthrope closed 4 years ago

djinn-anthrope commented 4 years ago

Line 106: parsed.download to parsed.path

Fix for https://github.com/inception-project/framenet-tools/issues/28

codecov-commenter commented 4 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   78.91%   78.91%           
=======================================
  Files          30       30           
  Lines        2419     2419           
=======================================
  Hits         1909     1909           
  Misses        510      510
Impacted Files Coverage Δ
framenet_tools/main.py 71.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c284c5...3620bf3. Read the comment docs.

djinn-anthrope commented 4 years ago

Looks ok, but I think the path should not include cwd in case we explicitly give it.

In case we explicitly give an absolute path, os.getcwd() gets ignored, as far as I can tell. And it works even if a relative path is provided, based on where the command is called. So, I don't see the problem?

jcklie commented 4 years ago

Thanks! I was not aware of that using absolute path behaviour