UKPLab / sentence-transformers

State-of-the-Art Text Embeddings
https://www.sbert.net
Apache License 2.0
15.41k stars 2.49k forks source link

[`training`] Pass `steps`/`epoch`/`output_path` to Evaluator during training #3066

Closed tomaarsen closed 6 days ago

tomaarsen commented 1 week ago

Resolves #3062

Hello!

Pull Request overview

Details

The model.fit nor SentenceTransformerTrainer passed all available parameters down to the evaluator(s). In particular, the output_path wasn't sent, which meant that no csv files could be written for the evaluators. Beyond that, 2 evaluators failed when writing to disk. Some better tests for the evaluators would be appreciated, as this could've been caught.

bluebalam commented 6 days ago

Thank you very much @tomaarsen for the quick response 👍🏾

tomaarsen commented 6 days ago

Gladly! You can use this already with:

pip install git+https://github.com/UKPLab/sentence-transformers.git

And otherwise this will be included in the next release.