UKRIN-MAPS / ukat

UKRIN Kidney Analysis Toolbox
https://www.nottingham.ac.uk/research/groups/spmic/research/uk-renal-imaging-network/ukrin-maps.aspx
GNU General Public License v3.0
12 stars 4 forks source link

Big Dependency Bump #203

Closed alexdaniel654 closed 1 year ago

alexdaniel654 commented 1 year ago

Proposed changes

Lots of dependencies were out of data and not compatible with each other. They're now mostly the first patch of the latest stable minor version. I've also changed the requirements from being greater than x.y.z to compatible with x.y.z e.g. numpy>=1.24.1 becomes numpy~=1.24.1 which is a good compromise between flexibility of install and consistent results.

Checklists

codecov[bot] commented 1 year ago

Codecov Report

Merging #203 (01e5f6d) into dev (7a292e3) will decrease coverage by 0.35%. The diff coverage is 67.50%.

@@            Coverage Diff             @@
##              dev     #203      +/-   ##
==========================================
- Coverage   97.97%   97.62%   -0.35%     
==========================================
  Files          41       41              
  Lines        3555     3581      +26     
==========================================
+ Hits         3483     3496      +13     
- Misses         72       85      +13     
Impacted Files Coverage Δ
ukat/mapping/tests/test_b0.py 98.41% <50.00%> (-0.79%) :arrow_down:
ukat/mapping/tests/test_diffusion.py 98.23% <50.00%> (-1.17%) :arrow_down:
ukat/mapping/tests/test_mtr.py 97.43% <50.00%> (-1.25%) :arrow_down:
ukat/mapping/tests/test_t1.py 99.11% <50.00%> (-0.45%) :arrow_down:
ukat/mapping/tests/test_t2.py 98.49% <50.00%> (-0.75%) :arrow_down:
ukat/mapping/tests/test_t2star.py 98.78% <50.00%> (-0.61%) :arrow_down:
ukat/qa/tests/test_snr.py 97.85% <50.00%> (-1.41%) :arrow_down:
ukat/segmentation/tests/test_whole_kidney.py 96.10% <50.00%> (-2.53%) :arrow_down:
ukat/vessels/tests/test_phase_contrast.py 98.00% <50.00%> (-1.32%) :arrow_down:
ukat/mapping/b0.py 100.00% <100.00%> (ø)
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

alexdaniel654 commented 1 year ago

Places where coverage drops are just the failsafe "delete any test_output folder that already exists" bit of the tests. Nothing to worry about.