Mapping Fit Signals - Githubissues

UKRIN-MAPS / ukat

UKRIN Kidney Analysis Toolbox

https://www.nottingham.ac.uk/research/groups/spmic/research/uk-renal-imaging-network/ukrin-maps.aspx

GNU General Public License v3.0

12 stars 4 forks source link

Mapping Fit Signals #221

Closed alexdaniel654 closed 7 months ago

alexdaniel654 commented 7 months ago

Proposed changes

Adds option to output the simulated signals from the fit model for all mapping methods. This can be generically useful but is going to be needed for model driven registration.

Checklists

[x] I have read and followed the CONTRIBUTING document
[x] This pull request is from and to the dev branch
[x] I have added tests that demonstrate the feature/fix works
[x] I have added necessary documentation (if appropriate)
[x] I have updated documentation which becomes obsolete after my changes (if appropriate)
[x] I have added/updated a notebook to demonstrate the changes (if appropriate)
[x] Files added follow the repository structure (if appropriate)

pep8speaks commented 7 months ago

Hello @alexdaniel654, thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated at 2024-03-21 09:48:02 UTC

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.96%. Comparing base (0bc7092) to head (0541aa3).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #221 +/- ## ========================================== + Coverage 97.92% 97.96% +0.04% ========================================== Files 48 48 Lines 4333 4433 +100 ========================================== + Hits 4243 4343 +100 Misses 90 90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.