search

UKZN-Astronomy / corrcal

Python/C code for calibration of quasi-redundant arrays. Different (fixed) algorithm from original corrcal
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

PEP8 Reformatting #16

Closed piyanatk closed 4 years ago

piyanatk commented 4 years ago

Python codes should be reformatted to PEP8. pylint can scan the codes and provide feedback on what to change. @ronniyjoseph, do you know if there is way to automatically reformat to PEP8?

ronniyjoseph commented 4 years ago

There's a package autopep8 (pip installable) that promises to do this. Although I've never used it.

Pycharm is and IDE (by Jetbrains and free for staff and students at universities!) that can do some amount of PEP8 checking and reformatting. I use Pycharm and usually ignore PEP8 suggestions until I am finished with projects and let it reformat the code. I could see if pycharm has useful feedback.

However, I think a lot of the PEP8 changes might require a bit more insight in the code.

piyanatk commented 4 years ago

I use Pycharm too. I will take a look.

piyanatk commented 4 years ago

As we discussed, we will postpone PEP8 reformatting until we are ready to merge the restructure branch to master

piyanatk commented 4 years ago

PR submitted https://github.com/UKZN-Astronomy/corrcal/pull/21

ronniyjoseph commented 4 years ago

I've reviewed the PR and there are a few things that need to be resolved before we can merge into master.

piyanatk commented 4 years ago

Close with merge https://github.com/UKZN-Astronomy/corrcal/pull/21