search

UKZN-Astronomy / corrcal

Python/C code for calibration of quasi-redundant arrays. Different (fixed) algorithm from original corrcal
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Put main package in src directory #30

Closed piyanatk closed 4 years ago

piyanatk commented 4 years ago

This PR fixes #23.

The new structure is not Python standard but is commonly used, and should prevent loading of compiled C library from the local development directory.

piyanatk commented 4 years ago

@steven-murray @ronniyjoseph Can either of you review this PR please?

steven-murray commented 4 years ago

@piyanatk I don't think the data/ folder is in the right place -- it's not being installed on my system.

piyanatk commented 4 years ago

@steven-murray https://github.com/UKZN-Astronomy/corrcal/pull/30/commits/404d32fb4e75e9ec5f9dddc70ba310c2daf05262 should fix that issue now.

ronniyjoseph commented 4 years ago

Sorry, I didn't have the time to look at it.

So on my install I had to change the path for LIB_LOC = glob(site.getsitepackages()[0] + "/corrcal/corrcal/c_corrcal.so")[0] in wrapper.py

Because the c_corrcal.so file is now one folder deeper.