search

ULHPC / puppet-slurm

A Puppet module designed to configure and manage SLURM(see https://slurm.schedmd.com/), an open source, fault-tolerant, and highly scalable cluster management and job scheduling system for large and small Linux clusters
Apache License 2.0
19 stars 24 forks source link

Optionally install build dependencies and MySQL #20

Closed gfa closed 5 years ago

gfa commented 5 years ago

Hello

I've used your Puppet module (thanks!) to bootstrap my Slurm cluster, in order to do so I have forked it and made some changes. I'll be sending PRs covering those changes

I don't deploy MySQL (it is managed by another team) nor build slurm on the nodes, this PR addresses those 2 differences. The default action remains the same, install MySQL and build Slurm

Let me know if you prefer smashed or individual commits

Falkor commented 5 years ago

That's fine like that. I'm still hesitating to promote that immediately or for the next minor release (current default).

runejuhl commented 5 years ago

Hi,

This PR seems to introduce a circular dependency which causes errors if running Puppetserver with strict_variables = true. I've patched it in https://github.com/runejuhl/puppet-slurm/commit/80aa55952fec12fc9c1d992d3eab5dad96bcd6c8 ; let me know if you want me to raise a PR.

gfa commented 5 years ago

Hi

I no longer use this module, neither have access to test it. If I would do this PR again I'll lookup the values of $munge_extra_packages and $pre_requisite_packages from hiera, if not declared in hiera set the default values in the module.

runejuhl commented 5 years ago

Hi @gfa

Yes, I'd prefer Hiera too; much nicer for such things. I'll raise another PR with your changes and mine.

Falkor commented 5 years ago

From the discussion, I'll close this pull request without merging then. Thanks @gfa nevertheless for the effort.