search

ULHPC / puppet-slurm

A Puppet module designed to configure and manage SLURM(see https://slurm.schedmd.com/), an open source, fault-tolerant, and highly scalable cluster management and job scheduling system for large and small Linux clusters
Apache License 2.0
19 stars 24 forks source link

Make the slurmctl class require that the config is present #30

Closed Rovanion closed 5 years ago

Rovanion commented 5 years ago

I found that slurm.conf was not deployed on puppet nodes configured to import slurm::slurmctld. In order to remedy this I made the slurmctld service require the class ::slurm::config before being deployed.

Falkor commented 5 years ago

Hum actually import is deprecated, you should better use include or one of its siblings, require and contain. Does it happen also with include (I do not notice it on my side)?

As the class include ::slurm::config (see slurmctld.pp#L42), I'm surprised you need to enforce the dependency here.

Rovanion commented 5 years ago

Eh, that was merely a mistyping from my part. include is the keyword I used, import is not used anywhere in my codebase.