search

UM-ARM-Lab / smmap_utilities

A small repository of common utilities that were split off of the smmap repository.
0 stars 0 forks source link

Added function denoiseWithDistanceConstraints(...) #5

Closed dmcconachie closed 6 years ago

dmcconachie commented 6 years ago

Check function signature and comments for form of optimization.

ChuplesKai commented 6 years ago

Overall this looks pretty good. There's just a few comments I put inline with the new function.

The original optimization function is much easier to read and it's nice that you've made it clearer to understand what the code is doing. The new function seems very generally useful.

I have no major qualms.