search

UM-Bridge / umbridge

UM-Bridge (the UQ and Model Bridge) provides a unified interface for numerical models that is accessible from virtually any programming language or framework.
https://um-bridge-benchmarks.readthedocs.io/en/docs/
MIT License
32 stars 14 forks source link

Remove time out in waitForFile function #issue-35 #44

Closed LennoxLiu closed 10 months ago

LennoxLiu commented 10 months ago

I've removed the time-out function in waitForFile, and replaced it with a while loop using std::filesystem::exists to check whether the file exists for every 1 second. The while loop will only exist when the file exists.

And I also tested it with the MultiplyBy2 model with HyperQueue.

Fixing #35

linusseelinger commented 10 months ago

@LennoxLiu There's a minor conflict with @chun9l 's latest change. Could you take care of that?

LennoxLiu commented 10 months ago

Sure.

On Wed, Jan 17, 2024, 11:02 Linus Seelinger @.***> wrote:

@LennoxLiu https://github.com/LennoxLiu There's a minor conflict with @chun9l https://github.com/chun9l 's latest change. Could you take care of that?

— Reply to this email directly, view it on GitHub https://github.com/UM-Bridge/umbridge/pull/44#issuecomment-1895475254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZBZ7LPYLVLZJ6UDA4EF45TYO6OTHAVCNFSM6AAAAABB5N5HP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGQ3TKMRVGQ . You are receiving this because you were mentioned.Message ID: @.***>

LennoxLiu commented 10 months ago

I removed the multiple checks in submitHQJob(), please check it.

linusseelinger commented 10 months ago

Looks good to me, thanks a lot!