UM-Bridge / umbridge

UM-Bridge (the UQ and Model Bridge) provides a unified interface for numerical models that is accessible from virtually any programming language or framework.
https://um-bridge-benchmarks.readthedocs.io/en/docs/
MIT License
32 stars 14 forks source link

Removing URL files when HQ jobs are cancelled #47

Open Schlevidon opened 10 months ago

Schlevidon commented 10 months ago

After #45 all old URL files are removed when starting the load balancer. Should we still remove the URL file whenever a HQ job is cancelled?

https://github.com/UM-Bridge/umbridge/blob/b9f3b1ec93a23adfea3bdfca0bdd57cea6fcad0f/hpc/LoadBalancer.hpp#L142

linusseelinger commented 10 months ago

I think we should still delete the url files after use. There might be millions of runs, so at some point the file system may become unhappy. We might think about some kind of verbose/debug output mode though if problems turn out frequent in practice. Good point about std::filesystem!