search

UM-PEPL / HallThruster.jl

An open-source fluid Hall thruster code
Other
16 stars 9 forks source link

Fix ShiftedTwoZoneBohm typo #102

Closed eckelsjd closed 8 months ago

eckelsjd commented 8 months ago

Getting this error: "UndefVarError: ShiftedTwoZone not defined" when calling run_simulation(). I believe the correct symbol in collisions/anomalous.jl is "ShiftedTwoZoneBohm".

Should check if this occurs anywhere else.

codecov-commenter commented 8 months ago

Codecov Report

Merging #102 (b271204) into main (8dc8733) will not change coverage. The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files          35       35           
  Lines        1992     1992           
=======================================
  Hits         1700     1700           
  Misses        292      292
Files Coverage Δ
src/simulation/simulation.jl 78.69% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8dc8733...b271204. Read the comment docs.

archermarx commented 8 months ago

Excellent, sorry about the typo. I was using it as an externally-implemented anom model and changed the name when I put it in the code.