codecov-commenter
commented
7 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.37%. Comparing base (
9b9247a) to head (8dde7da).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Theory on the non-uniform spacing weights can be found here: https://www.overleaf.com/read/ngjghgsndcmw#2da337
This commit should fix the weights on the smoothing step on line 57/62 (old/this commit) of electronenergy to correctly handle non-uniform grids.
I will update with a comment tomorrow, but as of this post this commit has passed the unit tests but I haven't tested performance/on a variety of simulations. Performance shouldn't be significantly changed speed wise as the number of calculations is small/might go down however, an additional array has been created that will increase memory usage.