Misc Updates

[DecBrick]

Couple of miscellaneous updates for the code & documentation:

1. Updated potential solver documentation to correctly describe how the code uses a discharge current calculation to find the electric field.
2. Added a unit test for update_plume_geometry along with some cleanup.

[archermarx]

Actually, looks like we have some failing tests. Can you check and see what those are about?

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.62%. Comparing base (ff183a1) to head (ef378f8). Report is 1 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL) ```diff @@ Coverage Diff @@ ## main #126 +/- ## ========================================== - Coverage 83.93% 83.62% -0.31% ========================================== Files 35 35 Lines 1942 1942 ========================================== - Hits 1630 1624 -6 - Misses 312 318 +6 ``` | [Files](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL) | Coverage Δ | | |---|---|---| | [src/simulation/plume.jl](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL#diff-c3JjL3NpbXVsYXRpb24vcGx1bWUuamw=) | `100.00% <100.00%> (ø)` | | | [src/simulation/potential.jl](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL#diff-c3JjL3NpbXVsYXRpb24vcG90ZW50aWFsLmps) | `95.65% <ø> (-0.35%)` | :arrow_down: | | [src/simulation/simulation.jl](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL#diff-c3JjL3NpbXVsYXRpb24vc2ltdWxhdGlvbi5qbA==) | `90.10% <100.00%> (-1.52%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL). Last update [1633a38...ef378f8](https://app.codecov.io/gh/UM-PEPL/HallThruster.jl/pull/126?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UM-PEPL).