UM-PEPL / HallThruster.jl

An open-source fluid Hall thruster code
Other
16 stars 9 forks source link

Issue with the tutorial and the running of the simulation #135

Closed bboyeleven closed 3 weeks ago

bboyeleven commented 3 weeks ago

Hi, I’m currently learning and using the package HallThruster.jl. At first running of the code available in the tutorial on my cmd (https://um-pepl.github.io/HallThruster.jl/dev/run/) everything was fine and I was getting the same results as in the tutorial. But now (3 days later) I wanted to try again but the graphics obtained are not the right ones and every of my simulation isn’t working as planned (the thrust for example is not zero for only the 1st element of the spatial discretization).

I don't know if the problem come from the code but may be from some wrong command entered in Julia or a background simulation still running.

Any ideas are welcome thx. Here are the plots that I got : Capture d'écran 2024-06-11 181216

archermarx commented 3 weeks ago

Hey thanks for reaching out. The tutorial is a bit out of date and needs to be redone. I'll see if I can get a new version out today.

On Thu, Jun 13, 2024, 7:59 AM bboyeleven @.***> wrote:

Hi, I’m currently learning and using the package HallThruster.jl. At first running of the code available in the tutorial on my cmd ( https://um-pepl.github.io/HallThruster.jl/dev/run/) everything was fine and I was getting the same results as in the tutorial. But now (3 days later) I wanted to try again but the graphics obtained are not the right ones and every of my simulation isn’t working as planned (the thrust for example is not zero for only the 1st element of the spatial discretization).

I don't know if the problem come from the code but may be from some wrong command entered in Julia or a background simulation still running.

Any ideas are welcome thx. Here are the plots that I got : Capture.d.ecran.2024-06-11.181216.png (view on web) https://github.com/UM-PEPL/HallThruster.jl/assets/172601348/a3c1ab8e-f3ec-429b-bb40-c6adf998a19f

— Reply to this email directly, view it on GitHub https://github.com/UM-PEPL/HallThruster.jl/issues/135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOP3QGWCQLDN5R57K3FJYVLZHGCSTAVCNFSM6AAAAABJIHZXGGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TAOJVHE3TQOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bboyeleven commented 3 weeks ago

Thanks it would be a great help. Have you ever encountered that kind of problem before ? I'm having the same problem with any type of configuration. Here is my code : `using HallThruster using Plots using Unitful

domain_of_study = (0.0, 0.05)

config_spt100_test = HallThruster.Config( ncharge = 1, discharge_voltage = 300u"V", thruster = HallThruster.SPT_100, domain = domain_of_study, anode_mass_flow_rate = 4.93u"mg/s", propellant = Xenon, neutral_velocity = 300.0u"m/s", ion_temperature = 500.0u"K", cathode_Te = 2.0u"eV", anode_Te = 2.5u"eV", ion_wall_losses = true, )

solution_spt100_test = HallThruster.run_simulation(config_spt100_test; grid= EvenGrid(200), nsave=200, dt=1e-8, duration=1e-3)

HallThruster.thrust(solution_spt100_test) HallThruster.discharge_current(solution_spt100_test)

plot(solution_spt100_test)`

archermarx commented 3 weeks ago

I found a bug that had affected the tutorial. If you update HallThruster.jl to version 14.3 (should be tagged within the hour) the bug should be fixed. I've also updated the tutorial so that it should work with the current version!

bboyeleven commented 3 weeks ago

Ok, thanks a lot ! I'll see if the problem is resolved by updating and re-launch my code. By curiosity what was the bug that you found ? I saw it was about ncells.

Apart from that : love your work 😉

EDIT : problem solved 👍

archermarx commented 3 weeks ago

Great to hear! The problem had to do with a change I made to store ncells in the params struct. In run_simulation, you can either specify an ncells, in which case an EvenGrid is constructed, or explicitly pass in a grid. I had handled the latter case but not the former, resulting in ncells being left at zero in the params struct.