search

UM-PEPL / HallThruster.jl

An open-source fluid Hall thruster code
Other
18 stars 10 forks source link

Adressed conflicts, added real v_c calculations using goebel and katz approximations #21

Closed dere4 closed 2 years ago

dere4 commented 2 years ago

readded test for ionization, everything should work fine now. Use global variable for Tev. added using StaticArrays to run.jl (dunno if you tried to do it differently, didnt figure it out though and SA wasn't defined). Also using actual electron and neutral densities for v_c calculations, and realistic Hall Thruster densities initially. Outcome makes sense on surface. Now trying to move on to what I wrote before.

dere4 commented 2 years ago

Also the @turbo sped up things quite a bit, its more than twice as fast now. Wouldn't it make sense to define all arrays used in update! as static arrays? afaik its about the size not mutability, so that would work no? U = zeros(nvariables, ncells+2) # need to allocate room for ghost cells. I mean all of these, except for A maybe: F = zeros(nvariables, nedges) UL = zeros(nvariables, nedges) UR = zeros(nvariables, nedges) Q = zeros(nvariables) A = Tridiagonal(zeros(ncells-1), zeros(ncells), zeros(ncells-1)) #for potential equation A*ϕ = b b = zeros(ncells) #for potential equation ϕ = zeros(ncells) #for potential equation Tev = zeros(ncells+2)

codecov[bot] commented 2 years ago

Codecov Report

Merging #21 (06fa1fd) into main (5f381d1) will increase coverage by 4.94%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   90.66%   95.61%   +4.94%     
==========================================
  Files          12       12              
  Lines         450      456       +6     
==========================================
+ Hits          408      436      +28     
+ Misses         42       20      -22
Impacted Files Coverage Δ
src/electrontransport.jl 100.00% <100.00%> (+30.76%) :arrow_up:
src/simulation.jl 91.30% <100.00%> (ø)
src/sourceterms.jl 100.00% <100.00%> (+26.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f381d1...06fa1fd. Read the comment docs.