search

UM-PEPL / HallThruster.jl

An open-source fluid Hall thruster code
Other
16 stars 9 forks source link

Config Struct #78

Closed dynamic-queries closed 3 days ago

dynamic-queries commented 1 year ago

It might be convenient to subsume the parameters of the Config Struct :

And store these two sub-structs in config. Thoughts ?

archermarx commented 1 year ago

Yes, that could work. We'd want to keep a convenience constructor though

On Thu, Dec 15, 2022, 5:57 AM Rahul Manavalan @.***> wrote:

It might be convenient to subsume the parameters of the Config Struct :

  • Simulation parameters -> Simulation_Struct
  • Model_parameters -> Model_Struct

And store these two sub-structs in config. Thoughts ?

— Reply to this email directly, view it on GitHub https://github.com/UM-PEPL/HallThruster.jl/issues/78, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOP3QGRZM75LRJDJWYNVC63WNL2Q3ANCNFSM6AAAAAAS7SV4GU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

archermarx commented 1 year ago

Reopening until we get a PR to do this

dynamic-queries commented 1 year ago

I'll open a PR today.

archermarx commented 3 days ago

Closing for now