UM-PEPL / HallThruster.jl

An open-source fluid Hall thruster code

Other

18 stars 10 forks source link

Integrated mms into simulation.jl functions #8

Closed dere4 closed 2 years ago

dere4 commented 2 years ago

a lot of commits but most of them didnt change much since I forgot to select the changes to commit. basically added a few terms to simulation tuple to facilitate mms. Uses boolean MMS to select actions in the simulation.jl functions and mms! for the actual terms to be added on the RHS. both are stored at MMS, mms! = params.mms .

archermarx commented 2 years ago

there's some failing tests, should make those pass before merging. you can check the output of the CI runs to see, but the simulation setup tests fail now and i would expect the freestream preservation test does too. both should be straightforward to fix.

dere4 commented 2 years ago

I updated dere4:main, the tests are fixed and mms is included, I think this pull requested was updated with it. cant create another one.

archermarx commented 2 years ago

Yep, this PR has been updated. Now waiting for tests to run

dere4 commented 2 years ago

added symbolics, which added a line to project.toml

dere4 commented 2 years ago

somehow I need to always commit twice

dere4 commented 2 years ago

added all packages I could find were included and missing. Added convergence to MMS, will now run either up to convergence or end time, is using callback TerminateSteadyState. https://diffeq.sciml.ai/stable/features/callback_library/ determines whether 1st derivatives are sufficiently small, used default values for now. Verified that it actually works, ie with the callback simulations stop earlier when giving sufficiently long end_time.

codecov[bot] commented 2 years ago

Codecov Report

Merging #8 (f86cf5b) into main (a8a21ab) will increase coverage by 0.07%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   96.63%   96.70%   +0.07%     
==========================================
  Files           9        9              
  Lines         327      334       +7     
==========================================
+ Hits          316      323       +7     
  Misses         11       11

Impacted Files	Coverage Δ
src/simulation.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8a21ab...f86cf5b. Read the comment docs.

archermarx commented 2 years ago

tests are passing, I'll take a look through the code

archermarx commented 2 years ago

looks great, merging now