feat(fpl): set fpl params during deployment

UMAprotocol / launch-lsp

CLI tool for launching a new LSP (Long-Short Pair). Relevant docs at Outcome.Finance: https://docs.outcome.finance/ and UMA: https://docs.umaproject.org/

GNU Affero General Public License v3.0

14 stars 13 forks source link

feat(fpl): set fpl params during deployment #11

Closed pemulis closed 3 years ago

pemulis commented 3 years ago

Signed-off-by: John Shutt pemulis@users.noreply.github.com

smb2796 commented 3 years ago

It doesn't look like the FPL params actually get set. I tested with a linear FPL deployment on kovan, and the deployment tx does not fail, but the logs return: `Financial product library parameters set in transaction: deployment tx (not the tx of setting the FPL params)".

Also verifying separately, the FPL params are not set for the the LSP.

smb2796 commented 3 years ago

@pemulis any updates on these comments?

pemulis commented 3 years ago

@pemulis any updates on these comments?

I've addressed the documentation comments and made a bunch of fixes related to the full list of parameters and I'm investigating the buggy deployment.

abg4 commented 3 years ago

This looks really good. I tested deploying for RangeBond, Linear, and CoveredCall and FPL params are being set accurately. FPL contract artifacts are missing for CappedYieldDollar, SuccessToken, and SimpleSuccessToken which is causing an error when deploying (at least for kovan which I am testing on). I am in the process of updating and will let you know when I am finished testing.