search

UMAprotocol / protocol

UMA Protocol Running on Ethereum
https://uma.xyz
GNU Affero General Public License v3.0
361 stars 175 forks source link

refactor: Tweak PublicNetworks etherscan formatting #4617

Closed pxrl closed 10 months ago

pxrl commented 11 months ago

Motivation Minor maintainability improvement.

Summary Remove the implicit requirement for appending a / to any block explorer entries in PublicNetworks.ts.

Details The createEtherscanLinkMarkdown() function appears to assume that the block explorer link is provided with a trailing /, but this imposes a requirement that the PublicNetworks entry includes a trailing /. The previous definition for Base Görli forgot this, so the links would not have been usable out of the box.

pxrl commented 11 months ago

Just throwing this one up as a suggestion - hence Draft PR.