feat(financial-templates-lib): preserve url in truncated discord ticket - Githubissues

UMAprotocol / protocol

UMA Protocol Running on Ethereum

https://uma.xyz

GNU Affero General Public License v3.0

361 stars 175 forks source link

feat(financial-templates-lib): preserve url in truncated discord ticket #4619

Closed Reinis-FRP closed 11 months ago

Reinis-FRP commented 11 months ago

Motivation

Improve Discord Ticket verification by trying to preserve URLs in the message when truncating due to Discord character limit. This would allow to retain sufficient pointers (e.g. Oracle UI link) when parts of the message are truncated.

Summary

Modifies Discord Ticket message truncating logic to try preserve included URLs.

Details

This may be unnecessary for some PRs. Catch-all for detailed explanations about the implementation decisions and implications of the change.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

[ ] Ran end-to-end test, running the code as in production
[ ] New unit tests created
[ ] Existing tests adequate, no new tests required
[ ] All existing tests pass
[x] Untested

Issue(s)

Fixes #XXXX

Reinis-FRP commented 11 months ago

Looks good! A test would be nice robot

Agree, added some truncation tests in 75d280bffba9587596236898680eb1ebb430bd7d