fix(financial-templates-lib): remove anchor text from pd links - Githubissues

UMAprotocol / protocol

UMA Protocol Running on Ethereum

https://uma.xyz

GNU Affero General Public License v3.0

361 stars 175 forks source link

fix(financial-templates-lib): remove anchor text from pd links #4622

Closed Reinis-FRP closed 11 months ago

Reinis-FRP commented 11 months ago

Motivation

When bot sends link in Markdown formatted as <URL|TEXT> the PagerDuty does not resolve URL correctly as |TEXT is added to URL.

Summary

Removes anchor text from links in PagerDuty transports.

Details

This uses removeAnchorTextFromLinks that was created for DiscordTicketTransport.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

[ ] Ran end-to-end test, running the code as in production
[ ] New unit tests created
[ ] Existing tests adequate, no new tests required
[ ] All existing tests pass
[x] Untested

Issue(s)

Fixes https://linear.app/uma/issue/UMA-1633/fix-markdown-links-for-pagerduty

linear[bot] commented 11 months ago

UMA-1633 Fix Markdown links for PagerDuty

When bot sends link in Markdown formatted as `` the PagerDuty does not resolve URL correctly as `|TEXT` is added to URL. Its possible that `createEtherscanLinkMarkdown` from `uma/common` can be fixed to include extra space around delimiting `|`, but have to check if this does not cause regression on other transports where `` formatting is working correctly