UMAprotocol / protocol

UMA Protocol Running on Ethereum
https://uma.xyz
GNU Affero General Public License v3.0
361 stars 175 forks source link

fix: remove cryptowatch related tests #4649

Closed Reinis-FRP closed 9 months ago

Reinis-FRP commented 9 months ago

Motivation

Kraken has shut down cryptowat.ch api causing some of monitors package tests to fail and block new PRs. We don't run any financial contract bots, so this should not affect security.

Summary

Removes financial contract tests in monitors that required cryptowat.ch api access.

Details

We might want to delete all financial contract support in bots in a separate PR.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

Issue(s)

Fixes https://linear.app/uma/issue/UMA-1876/cryptowatch-api-no-longer-works-causing-ci-to-fail

linear[bot] commented 9 months ago
UMA-1876 cryptowatch api no longer works, causing CI to fail

see these examples: [https://app.circleci.com/pipelines/github/UMAprotocol/protocol/22127/workflows/ba05f1e7-d553-4ab9-90f9-b553da1d276c/jobs/197948](https://app.circleci.com/pipelines/github/UMAprotocol/protocol/22127/workflows/ba05f1e7-d553-4ab9-90f9-b553da1d276c/jobs/197948) [https://app.circleci.com/pipelines/github/UMAprotocol/protocol/22127/workflows/ba05f1e7-d553-4ab9-90f9-b553da1d276c/jobs/197942](https://app.circleci.com/pipelines/github/UMAprotocol/protocol/22127/workflows/ba05f1e7-d553-4ab9-90f9-b553da1d276c/jobs/197942) it looks like some tests we have depend on cryptowatch, which is no longer running. we will need to disable these