feat: add logger package

UMAprotocol / protocol

UMA Protocol Running on Ethereum

https://uma.xyz

GNU Affero General Public License v3.0

361 stars 175 forks source link

feat: add logger package #4663

Closed md0x closed 8 months ago

md0x commented 8 months ago

Changes proposed in this PR:

This PR adds a standalone logger package with minimal dependencies. It addresses compatibility issues encountered when using financial-templates with ethers v6.x

md0x commented 8 months ago

maybe i missed this discussion but why is this a whole new package?

Hey @daywiss, we cannot import the Logger we use everywhere in the bots from financial-templates in oev-backrunner because it has ethers v5.x nested in some dependencies and in oev-backrunner we use ethers v.6.x.

The easiest and cleanest was to create a new package with the logger

chrismaree commented 8 months ago

Should we also drop this code from financial-templates-lib and replace it with a re-export of this code? I gave the same feedback offline :) I think @md0x is going to do such.