feat: skip disputes and execution for blacklisted assertions - Githubissues

UMAprotocol / protocol

UMA Protocol Running on Ethereum

https://uma.xyz

GNU Affero General Public License v3.0

361 stars 175 forks source link

feat: skip disputes and execution for blacklisted assertions #4666

Closed Reinis-FRP closed 7 months ago

Reinis-FRP commented 7 months ago

Motivation

oSnap execution module is spamming notification channel for proposals that are known to be misconfigured and will be reverting.

Summary

Adds ability to selectively blacklist automated proposal dispute/execution.

Details

We identify proposals by their assertionId's that are guaranteed to be unique.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

[ ] Ran end-to-end test, running the code as in production
[x] New unit tests created
[ ] Existing tests adequate, no new tests required
[ ] All existing tests pass
[ ] Untested

Issue(s)

Fixes https://linear.app/uma/issue/UMA-2024/osnap-bot-trying-to-execute-bad-proposal-over-and-over

linear[bot] commented 7 months ago

UMA-2024 osnap bot: trying to execute bad proposal over and over

what's happening in [\#zbot-osnap-users](https://risklabs.slack.com/archives/C0548M76C94)? Notifications been going crazy for 48hrs now. oh, I see - its the epochisland proposal that was misconfigured. They eventually made a new fixed proposal, but our bot is still trying to execute the old one that is reverting. This is spamming the channel, so we should add some logic to decide when to stop execution attempts [https://risklabs.slack.com/archives/C050KJ2CYP6/p1699871047220039](https://risklabs.slack.com/archives/C050KJ2CYP6/p1699871047220039)