search

UMAprotocol / protocol

UMA Protocol Running on Ethereum
https://uma.xyz
GNU Affero General Public License v3.0
361 stars 175 forks source link

chore: add dispute assertion function to oov3 interface #4669

Closed pedrovalido closed 6 months ago

pedrovalido commented 7 months ago

Motivation

Closes #4668

Summary

Adding function to oov3 interface.

Details

Recently integrated uma protocol at ethglobal istanbul and found out the oov3 interface didnt contain the disputeAssertion function and had to add it manually.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

No testing needed as this is just adding a function to an interface. forge build seems to throw no issues related to the added function.

Issue(s)

Fixes #4668

pedrovalido commented 7 months ago
image

@mrice32 looks like it doesnt find the Test.sol file in the foundry lib. Not sure if this is a CI problem or not. Maybe the CI needs to do forge install do get the forge libs?

pedrovalido commented 7 months ago

trying to help but dont know a lot about your CI setup.

From the ci logs, looks like this file is failing to import Test.sol .

image

It is a bit strange though. Im able to run everything locally and I have the file locally after setting up the repo. So, maybe something to do with the CI setup?

image
mrice32 commented 6 months ago

@pedrovalido We finally got to the bottom of the issue in ci. Sorry for the delay. I think if you merge master into your branch, it should work now. This PR should have fixed the issue.

pedrovalido commented 6 months ago

Merge and the checks pass now :) @mrice32

daywiss commented 6 months ago

thanks @pedrovalido and @mrice32!